ci: replace Dockerized shfmt with direct binary install#291
Merged
Conversation
The mvdan/shfmt:v3 Docker image is not version-pinned and requires a docker pull on every PR. Install the shfmt binary directly from GitHub releases instead, matching the version used in .pre-commit-config.yaml (v3.13.1). Avoids a container pull while keeping behaviour identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mvdan/shfmt:v3Docker image in theshfmtjob is not version-pinned and triggers adocker pullon every PR run.Replace it with a direct binary download from GitHub releases, pinned to
v3.13.1— matching the version already specified in.pre-commit-config.yaml. The shfmt flags andgit diffcheck are unchanged.